Skip to content

Fix/sc #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix/sc #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e219a85
fix: scorecard mapping
eisbilir Mar 23, 2023
194c14e
fix: scorecard mapper
eisbilir Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/common/Constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,24 @@ export const ChallengeStatuses = {
New: "New",
Active: "Active",
};

export const PhaseTypeIds = {
Registration: 1,
Submission: 2,
Screening: 3,
Review: 4,
Appeals: 5,
AppealsResponse: 6,
Aggregation: 7,
AggregationReview: 8,
FinalFix: 9,
FinalReview: 10,
Approval: 11,
PostMortem: 12,
SpecificationSubmission: 13,
SpecificationReview: 14,
CheckpointSubmission: 15,
CheckpointScreening: 16,
CheckpointReview: 17,
IterativeReview: 18,
};
75 changes: 48 additions & 27 deletions src/util/LegacyMapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _ from "lodash";
import { PrizeSetTypes } from "../common/Constants";
import { PhaseTypeIds, PrizeSetTypes } from "../common/Constants";
import { V4_SUBTRACKS, V5_TO_V4 } from "../common/ConversionMap";
import { Challenge_Phase } from "../models/domain-layer/challenge/challenge";
import { legacyChallengeStatusesMap } from "./constants";
Expand Down Expand Up @@ -207,7 +207,7 @@ class LegacyMapper {


return {
1: this.mapScorecard(subTrack, phase.name), // Scorecard ID
1: this.mapScorecard(subTrack, this.mapPhaseNameToPhaseTypeId(phase.name)), // Scorecard ID
2: phase.name === "Registration" ? '1' : undefined, // Registration Number
3: phase.name === "Submission" ? submissionPhaseConstraint?.value.toString() ?? // if we have a submission phase constraint use it
reviewPhaseConstraint?.value != null ? '1' : undefined // otherwise if we have a review phase constraint use 1
Expand Down Expand Up @@ -278,39 +278,60 @@ class LegacyMapper {
}

// prettier-ignore
private mapScorecard(subTrack: string, phase: string): string | undefined {
private mapScorecard(subTrack: string, phaseTypeId: number | undefined): string | undefined {
const isNonProd = process.env.ENV != "prod";

// TODO: Update scorecard ids for all subtracks and check for dev environment

let scorecard = undefined;

// F2F
if (subTrack === V4_SUBTRACKS.FIRST_2_FINISH) scorecard = isNonProd ? 30002160 : 30002160; // missing dev scorecard
if (subTrack === V4_SUBTRACKS.DESIGN_FIRST_2_FINISH) scorecard = isNonProd ? 30001610 : 30001101; // missing dev scorecard

// QA
if (subTrack === V4_SUBTRACKS.BUG_HUNT) {
if (phase === "Review") scorecard = isNonProd ? 30001610 : 30001220; // missing dev scorecard
if (phase === "Specification Review") scorecard = isNonProd ? 30001610 : 30001120; // missing dev scorecard
if (
subTrack === V4_SUBTRACKS.FIRST_2_FINISH &&
phaseTypeId === PhaseTypeIds.IterativeReview
) {
scorecard = isNonProd ? 30002160 : 30002160;
} else if (
subTrack === V4_SUBTRACKS.DESIGN_FIRST_2_FINISH &&
phaseTypeId === PhaseTypeIds.Review
) {
scorecard = isNonProd ? 30001610 : 30001101;
} else if (subTrack === V4_SUBTRACKS.BUG_HUNT) {
if (phaseTypeId === PhaseTypeIds.Review) {
scorecard = isNonProd ? 30001610 : 30001220;
} else if (phaseTypeId === PhaseTypeIds.SpecificationReview) {
scorecard = isNonProd ? 30001610 : 30001120;
}
} else if (
subTrack === V4_SUBTRACKS.DEVELOP_MARATHON_MATCH &&
phaseTypeId === PhaseTypeIds.Review
) {
scorecard = isNonProd ? 30001610 : 30002133;
} else if (
subTrack === V4_SUBTRACKS.MARATHON_MATCH &&
phaseTypeId === PhaseTypeIds.Review
) {
scorecard = isNonProd ? 30001610 : 30002133;
} else if (subTrack === V4_SUBTRACKS.WEB_DESIGNS) {
if (phaseTypeId === PhaseTypeIds.SpecificationReview) {
scorecard = isNonProd ? 30001610 : 30001040;
} else if (phaseTypeId === PhaseTypeIds.CheckpointScreening) {
scorecard = isNonProd ? 30001610 : 30001364;
} else if (phaseTypeId === PhaseTypeIds.CheckpointReview) {
scorecard = isNonProd ? 30001610 : 30001004;
} else if (phaseTypeId === PhaseTypeIds.Screening) {
scorecard = isNonProd ? 30001610 : 30001363;
} else if (phaseTypeId === PhaseTypeIds.Review) {
scorecard = isNonProd ? 30001610 : 30001031;
} else if (phaseTypeId === PhaseTypeIds.Approval) {
scorecard = isNonProd ? 30001610 : 30000720;
}
} else if (
subTrack === V4_SUBTRACKS.CODE &&
phaseTypeId === PhaseTypeIds.Review
) {
scorecard = isNonProd ? 30002133 : 30002133;
}

// DS
if (subTrack === V4_SUBTRACKS.DEVELOP_MARATHON_MATCH) scorecard = isNonProd ? 30001610 : 30002133; // missing dev scorecard
if (subTrack === V4_SUBTRACKS.MARATHON_MATCH) scorecard = isNonProd ? 30001610 : 30002133; // missing dev scorecard

// DESIGN
if (subTrack === V4_SUBTRACKS.WEB_DESIGNS) {
if (phase === "Specification Review") scorecard = isNonProd ? 30001610 : 30001040; // missing dev scorecard
if (phase === "Checkpoint Screening") scorecard = isNonProd ? 30001610 : 30001364; // missing dev scorecard
if (phase === "Checkpoint Review") scorecard = isNonProd ? 30001610 : 30001004; // missing dev scorecard
if (phase === "Screening") scorecard = isNonProd ? 30001610 : 30001363; // missing dev scorecard
if (phase === "Review") scorecard = isNonProd ? 30001610 : 30001031; // missing dev scorecard
if (phase === "Approval") scorecard = isNonProd ? 30001610 : 30000720; // missing dev scorecard
}

if (subTrack === V4_SUBTRACKS.CODE) scorecard = isNonProd ? 30002133 : 30002133; // missing dev scorecard

return scorecard ? scorecard.toString() : undefined;
}
}
Expand Down