PM-1384 Fix date picker in copilot form #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -76,7 +77,8 @@ const InputDatePicker: FC<InputDatePickerProps> = (props: InputDatePickerProps) | |||
| const datePickerRef = useRef<ReactDatePicker<never, undefined>>(null) | |||
| const years = useMemo(() => { | |||
| const maxYear = getYear(props.maxDate ? props.maxDate : new Date()) + 1 | |||
| return range(1979, maxYear, 1) | |||
| const minYear = getYear(props.minYear ? props.minYear : 1979) | |||
| return range(minYear, maxYear, 1) | |||
| }, [props.maxDate]) | |||
There was a problem hiding this comment.
The dependency array for useMemo should include props.minYear as it is used to calculate minYear. This ensures that the memoized value updates correctly when props.minYear changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1384
What's in this PR?
Removes the previous years and shows only current and next two years in the year dropdown of date picker