Skip to content

TC API: Fix these issues raised during the review #202

@Sande3p

Description

@Sande3p

Env:

Base branch: develop-temp

Requirement

  1. The helper.getPhaseStatus should use phases' isOpen and dates to determine status, no need to use challengeDetails.status.
    See:
    https://discussions.topcoder.com/discussion/2041/clarification-regarding-challenge-phase-data
    "avoid using challengeDetails.status"

  2. The helper.getPhaseStatus should use phase's dates to check whether phase is shceduled or closed,
    it should not assume the phases are sorted by date in ascending order.

  3. In SubmissionService, listSubmissionsQuerySchema.challengeId should accept only uuid

  4. In SubmissionService, createSubmission.schema.entity.challengeId should accept only uuid

  5. In SubmissionService, updateSubmission.schema.entity.challengeId should accept only uuid

  6. In SubmissionService, patchSubmission.schema.entity.challengeId should accept only uuid

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions