[$50] Search issues in RB and WP

[sandhiyakavi]

Description:

1. Not able to fetch RB details when searching with ProjectId
2. Not able to get WP when searching with ResourceBooking Id. (WP seems to be not getting created)

[nkumar-topcoder]

@eisbilir
Resourcebooking status with placed status are not getting displayed in frontend or via Resourcebooking search API.

For example :

1. {{URL}}/resourceBookings?projectId=17333 has 7 RB records with placed status but it shows only 4 records now.
2. The reason as we suspect is due to this line but I am not sure of that - can you please check.
   

   taas-apis/src/services/ResourceBookingService.js

   Line 482 in c63d47e

   nested: {

3. i,e May be the ES is search condistion includes to have workperiod records too ? In our context it will always be empty during initials stage of RB record creation with placed status
4. Can you fix this ASAP please. Also, note that check if similar issue is exists anywhere else in the code.

Another issue reported but i am unablee to re-create that, Workperiod not getting created
@maxceem pls add

[maxceem]

@eisbilir

• as per our findings if ResourceBooking doesn't have start/end (and as a consequence it doesn't have WPs) it is not returned by the endpoint /resourceBookings/?projectId={{projectId}} when we search by projected for example.
• another thing to check. It looks like for WP to be returned it needs WP payments. somehow these nested records have become mandatory (when you search for WP using RB id, its not returning WPs. But its returning WP when searching with project ID.) - UPDATED: looks like not an issue and works good.

not returning data if nested records are empty

Another issue reported but i am unablee to re-create that, Workperiod not getting created

@narekcat I haven't noticed such an issue.

[narekcat]

Hi @maxceem . I can work on this issue, if you assign it to me.

[maxceem]

thanks, @narekcat, I prefer that eisbilir takes care of this one, as he was the one who implemented this code.
If eisbilir could not start within 24 hours, I would assign you.

[narekcat]

@maxceem Ok.

[maxceem]

@eisbilir, please sign-up with Topcoder X tool

This is an automated message for maxceem via Topcoder X

[eisbilir]

@maxceem
PR created #256
fixed the issue: not able to search RBs which has no nested WP data
not related but I discovered another issue and fixed: WPs are not getting deleted when RB's startDate or endDate updated to null
RB and WP related GET endpoints now work good (for ES and DB) wheter they have nested data or not.

[sandhiyakavi]

@maxceem @eisbilir Able to fetch RB details with project ID now. But rate type for RB will be by default 'Weekly' but now displayed as 'monthly' is it by default? (RB added through RCRM)

The Workperiod is getting displayed now but not all WP are getting created. RB with date 05/02/2021 - 05/24/2021 has only one WP with 05/09/2021 - 05/15/2021