Skip to content

add more logs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

add more logs #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/shared/topcoder/challenges.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export class TopcoderChallengesService {
}
});

this.logger.log(`Fetching challenges from: ${url.toString()}`);
const stringUrl = url.toString();
this.logger.log(`Fetching challenges from: "${stringUrl}"`);

const headers: Record<string, string> = {
'Content-Type': 'application/json',
Expand All @@ -35,12 +36,17 @@ export class TopcoderChallengesService {
}

this.logger.log(
`Fetching challenges with headers: ${JSON.stringify(headers)}`,
`Fetching challenges with headers: "${JSON.stringify(headers)}"`,
);

return fetch(url.toString(), {
method: 'GET',
headers,
});
try {
return await fetch(stringUrl, {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high
correctness
The await keyword is used here, but the function is not marked as async. This will result in a syntax error. Ensure the function is declared as async to handle the await correctly.

method: 'GET',
headers,
});
} catch (error) {
this.logger.error(`Error fetching challenges: ${JSON.stringify(error)}`, error);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
readability
Consider using error.message instead of JSON.stringify(error) for logging the error message. JSON.stringify might not serialize the error object as expected, leading to loss of information.

throw error;
}
}
}