-
Notifications
You must be signed in to change notification settings - Fork 51
PM-1178 Update copilot requests form link #1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -18,6 +18,7 @@ module.exports = { | |||
CHALLENGE_TRACKS_URL: `${PROD_API_HOSTNAME}/v5/challenge-tracks`, | |||
CHALLENGE_PHASES_URL: `${PROD_API_HOSTNAME}/v5/challenge-phases`, | |||
CHALLENGE_TIMELINES_URL: `${PROD_API_HOSTNAME}/v5/challenge-timelines`, | |||
COPILOTS_URL: `https://copilots.${DOMAIN}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a consistent naming convention for the URL constants. For example, you might want to rename COPILOTS_URL
to COPILOT_REQUEST_FORM_URL
to make it clear that this URL is specifically for the copilot request form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himaniraghav3 Looks good.
Can we also clean up code base from TYPEFORM_URL
as it won't be needed anymore?
@@ -58,6 +59,5 @@ module.exports = { | |||
SKILLS_V5_API_URL: `${API_V5}/standardized-skills/skills/autocomplete`, | |||
UPDATE_SKILLS_V5_API_URL: `${API_V5}/standardized-skills/challenge-skills`, | |||
SALESFORCE_BILLING_ACCOUNT_LINK: 'https://topcoder.my.salesforce.com/apex/baredirect?id=', | |||
TYPEFORM_URL: 'https://topcoder.typeform.com/to/YJ7AL4p8', | |||
PROFILE_URL: 'https://profiles.topcoder.com/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TYPEFORM_URL
constant has been removed, but the new copilot request form link should be added as a replacement to ensure the functionality is updated as per the pull request description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
https://topcoder.atlassian.net/browse/PM-1178
Updates the
Request Copilot
button link from typeform to the new copilot request form