-
Notifications
You must be signed in to change notification settings - Fork 51
Add render_patterns management command for static export and automated render check (#17, #18) #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
16b0a5e
to
fe17d4f
Compare
6ad305b
to
75eb144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One actual point, and one minor semantic point about stdout
vs. stderr
, but otherwise LGTM.
75eb144
to
68ff2cd
Compare
f44c129
to
16abc21
Compare
I’ve fixed what you reported @bcdickinson, and additionally added an argument to configure whether the rendered templates should be wrapped in the base template or not. I’ll now merge this as-is – I think it’s good to go apart from missing documentation, which I’ve intentionally removed but will add as a separate PR. |
Addresses #17 and #18.
Type of change
Please delete options that are not relevant.
Checklist: