Skip to content

Add render_patterns management command for static export and automated render check (#17, #18) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 2, 2020

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Sep 24, 2020

Addresses #17 and #18.

./manage.py render_patterns

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@thibaudcolas thibaudcolas added enhancement New feature or request storybook Usage of Storybook will affect this django Related to Django templates capabilities labels Sep 24, 2020
@thibaudcolas thibaudcolas added this to the Nice to have milestone Sep 24, 2020
@thibaudcolas thibaudcolas force-pushed the feature/17-18-render-patterns-command branch from 16b0a5e to fe17d4f Compare September 24, 2020 09:33
@thibaudcolas thibaudcolas changed the title Add first draft render_patterns management command Add render_patterns management command for static export and automated render check (#17, #18) Sep 24, 2020
@thibaudcolas thibaudcolas force-pushed the feature/17-18-render-patterns-command branch from 6ad305b to 75eb144 Compare September 24, 2020 16:53
Copy link

@bcdickinson bcdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One actual point, and one minor semantic point about stdout vs. stderr, but otherwise LGTM.

@thibaudcolas thibaudcolas force-pushed the feature/17-18-render-patterns-command branch from 75eb144 to 68ff2cd Compare November 2, 2020 13:58
@thibaudcolas thibaudcolas force-pushed the feature/17-18-render-patterns-command branch from f44c129 to 16abc21 Compare November 2, 2020 15:58
@thibaudcolas
Copy link
Member Author

I’ve fixed what you reported @bcdickinson, and additionally added an argument to configure whether the rendered templates should be wrapped in the base template or not.

I’ll now merge this as-is – I think it’s good to go apart from missing documentation, which I’ve intentionally removed but will add as a separate PR.

@thibaudcolas thibaudcolas merged commit ddb1065 into master Nov 2, 2020
@thibaudcolas thibaudcolas deleted the feature/17-18-render-patterns-command branch November 2, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Related to Django templates capabilities enhancement New feature or request storybook Usage of Storybook will affect this
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants