Make it possible to navigate the menu with the keyboard. Fix #202 #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the pattern library uses the menu item heading tags to listen for events which open and close their child menus. This is not accessible for users who navigate via keyboard only.
This MR resolves that by changing the menu item elements to buttons. In turn it also resolves #202.
It also:
.sidebar
to a new element.sidebar__inner
as when the sidebar is collapsed the padding meant the elements within the sidebar were still visible.whitelist_externals
is replaced byallowlist_externals
- https://tox.wiki/en/latest/changelog.html#deprecations-and-removals-4-0-0rc4Fixes #202
Checklist