Skip to content

Remove forced patterns #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 29, 2020
Merged

Remove forced patterns #83

merged 12 commits into from
Jul 29, 2020

Conversation

thibaudcolas
Copy link
Member

In GitLab by @todd-dembrey on Feb 2, 2019 4:28pm

TODO:

  • Tests
  • Update documentation
  • Describe usage of SECTIONS config
  • Describe default config

@thibaudcolas thibaudcolas added the enhancement New feature or request label Feb 19, 2020
@thibaudcolas
Copy link
Member Author

In GitLab by @bcdickinson on Oct 21, 2019 9:27am GMT+0100

So I had some downtime during Django Girls and I've rebased and tweaked this and got it running in the tests app. It mostly LGTM, I like the way the settings work now and having the flexibility to organise patterns across several locations and with configurable groups is great.

The outstanding things are:

  • It still needs tests
  • The documentation needs updating
  • I think it could do with a bit more thought about a default value for the PATTERN_LIBRARY['SECTIONS'] settings. Let's ask some FE bods.
  • I think pattern_library.utils is getting messy and confusing. In particular, get_pattern_templates could do with a bit of a scrub and some comments.

@thibaudcolas
Copy link
Member Author

@bcdickinson when you have the chance, could you update the PR’s description to detail what this PR does. It’s not entirely clear to me at first sight (although your comment helps).

@thibaudcolas thibaudcolas changed the title WIP: Feature/remove forced patterns WIP: Remove forced patterns Feb 24, 2020
@thibaudcolas thibaudcolas added this to the Nice to have milestone Feb 24, 2020
@thibaudcolas thibaudcolas mentioned this pull request Feb 28, 2020
10 tasks
@bcdickinson bcdickinson force-pushed the feature/remove-forced-patterns branch from 27a8730 to b7ca5bb Compare July 29, 2020 07:56
@bcdickinson bcdickinson changed the title WIP: Remove forced patterns Remove forced patterns Jul 29, 2020
@bcdickinson bcdickinson merged commit 96f9dfb into master Jul 29, 2020
@bcdickinson bcdickinson deleted the feature/remove-forced-patterns branch July 29, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Any HTML file readable by the app can be rendered and have the template source exposed
2 participants