Allow specificion of trusted downstream proxies for xheaders #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roxy hosts to be skipped in the `X-Forwarded-For` chain when using the `xheaders` option.
|
Thanks! |
This was referenced Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address the limitation whereby only the closest host in the
X-Forwarded-Forheader may be used as the remote ip address. The developer may now specify a list of trusted downstream proxy hosts that will be skipped in parsing the X-Forwarded-For header.This is analogous to similar functionality offered by Squid and Nginx. I discussed this in ticket #1840. I'll create a separate PR for proxies that include their connection port in their
X-Forwarded-Forentry.