tweak comment highlighting #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhduvall
commented
Sep 29, 2022
dhduvall
commented
- eliminate conflict between Go template comments and actions
- allow newlines between action and comment delimiters
- eliminate conflict between Go template comments and actions - allow newlines between action and comment delimiters
|
This is sort of quick and dirty, but ends up highlighting legal comments for me. It'd be nice to put the action delimiters into a separate highlight group from the comment itself, and it'd be nice to highlight as an error when the comment doesn't match the spec (there's something else besides the comment in the action, or when there's no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.