-
-
Notifications
You must be signed in to change notification settings - Fork 533
Add coverage reporting #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
FWIW I use codecov for qutebrowser too and I'm quite happy with it. |
Problem: A lot of the tests are run in a subprocess. There is a special wrapper class implementing that as part of the pytest plugin. Coverage needs to be made aware of that as described here. I am still in the process of learning about it and trying to find out how others are dealing with this. At the moment I am tempted to circumvent the proposed and just bake it right into the wrapper by checking if this is a coverage run and then replacing the python invocation with a coverage run invocation. Don't know if good idea or stupid yet though. |
Why not use pytest-cov which takes care of subprocess coverage automagically? |
Does it? Oh great. I wasn't aware of that. Thanks! |
Wow - first paragraph in the README :) I started reading through the coverage docs instead and from that angle it looks much more involved :) |
yeah I use pytest-cov for all my projects, works great 👍 |
Branch coverage would be nice but has a problem atm: pytest-dev/pytest-cov#168 keeping this open until resolved. |
Found a workaround for that (pass config file on command line), so we can close this. |
I am aware that there are different opinions about coverage, but to me it is a helpful data point, so I would like to add coverage reporting to our CI builds.
To me https://codecov.io looks good
The text was updated successfully, but these errors were encountered: