Fix bug with incorrectly defactorized dependencies #768 #1057
Conversation
New version with improved changes, fixing errors raised with the previous version: tox-dev#899 tox-dev#906
|
|
||
| x = self._replace_if_needed(x, name, replace, crossonly) | ||
| # print "getstring", self.section_name, name, "returned", repr(x) | ||
| return x |
There was a problem hiding this comment.
the comment here is redundant
There was a problem hiding this comment.
The comment is not mine, I kept it as it was already in the code.
I would prefer to not having commented code. If you do prefer I can simply remove it.
| assert packages == ["bar"] | ||
|
|
||
| # https://github.com/tox-dev/tox/issues/899 | ||
| def test_regression_test__issue_899(self, newconfig): |
There was a problem hiding this comment.
would prefer a name that explains the edge case comparison, so maintainers don't need to feed the issue in detail
| [testenv] | ||
| skip_install = True | ||
| sitepackages = True | ||
| passenv = |
There was a problem hiding this comment.
also please remove lines not essential to reproduce the bug, it just makes hard to read the test case
| ] | ||
|
|
||
| # https://github.com/tox-dev/tox/issues/906 | ||
| def test_regression_test__issue_906(self, newconfig): |
|
|
||
| x = self._replace_if_needed(x, name, replace, crossonly) |
There was a problem hiding this comment.
we should have here some explanation of why the repetition of same commands is needed as a comment
There was a problem hiding this comment.
OK, I'll try to summarize the issue as much as I can.
New version with improved changes, fixing errors raised
with the previous version:
#899
#906
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,miscsuperuser."CONTRIBUTORS(preserving alphabetical order)