-
-
Notifications
You must be signed in to change notification settings - Fork 536
Bracketed escaping #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bracketed escaping #1709
Conversation
) | ||
envconfig = config.envconfigs["python"] | ||
# This fails: ConfigError: substitution key 'b c' not found | ||
# assert envconfig.setenv["FOO"] == "a{b c}d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
highlighting this as what fails with the incomplete implementation.
d731d1d
to
4c4d5c7
Compare
Incomplete.
4c4d5c7
to
89b1e0e
Compare
I would prefer not to introduce new ways of doing things. As such only |
I am also not convinced about adding those; I've tried to lay out the problems at That commit in this PR is mostly to show where the problem exists, so anyone can play with it if they think it is easy to solve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now has merge conflicts.
I'll close this for now until you can attend to the PR again. Once you've done we can reopen. |
Adds
{\}
,{{}
and{}}
as an escaping mechanism in settings.{{}
and{}}
are not implemented so they can be used safely together.Additional coding is needed to handle values from the engine being pushed
back into the engine, so they are re-escaped.
Fixes #1708
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
<your username>
"superuser
."CONTRIBUTORS
(preserving alphabetical order)