Skip to content

Follow recommendations for FORCE_COLOR #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jugmac00
Copy link
Member

When the FORCE_COLOR variable is present and not an empty string, it forces ANSI color to be set. Previously, only yes, true or 0 were valid values.

See https://force-color.org/.

Fixes #3579

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

When the `FORCE_COLOR` variable is present and not an empty string, it forces
ANSI color to be set. Previously, ony `yes`, `true` or `0` were valid values.

See https://force-color.org/.

Fixes tox-dev#3579
@jugmac00
Copy link
Member Author

Regarding documentation... we could link to https://force-color.org/ from https://tox.wiki/en/4.28.4/config.html, but we don't do this for other variables.

@jugmac00
Copy link
Member Author

Test failures do not seem to be related and origin in virtualenv

E   ModuleNotFoundError: No module named 'winreg'

I will be off today, and will look tomorrow again. Maybe @gaborbernat has an immediate idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tox crashes with FORCE_COLOR is some arbitrary string
1 participant