Skip to content

use IOError and check error number (py2/py3 compat) #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2017
Merged

use IOError and check error number (py2/py3 compat) #582

merged 2 commits into from
Aug 22, 2017

Conversation

obestwalter
Copy link
Member

FileNotFoundError was introduced in Python3, so this is not compatible with python2.

@obestwalter
Copy link
Member Author

I'd like to merge this and make it part of an rc2 soon. Anyone opposed?

@nicoddemus
Copy link
Member

Sounds good to me! 👍

@gaborbernat
Copy link
Member

agreed 👍

@obestwalter obestwalter merged commit dfc8dc7 into tox-dev:master Aug 22, 2017
@obestwalter
Copy link
Member Author

thanks :)

@obestwalter obestwalter deleted the make-py2-compatible-again branch August 27, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants