Skip to content

Use string types check #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2017
Merged

Use string types check #627

merged 1 commit into from
Sep 10, 2017

Conversation

obestwalter
Copy link
Member

as suggested here: #617 (review)

@obestwalter
Copy link
Member Author

I have to up my git foo seriously, when juggling different changeset ... sigh

@codecov
Copy link

codecov bot commented Sep 10, 2017

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          11       11           
  Lines        2357     2357           
=======================================
  Hits         2208     2208           
  Misses        149      149
Impacted Files Coverage Δ
tox/_pytestplugin.py 93.97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a7c22...99594fc. Read the comment docs.

@obestwalter
Copy link
Member Author

that's better :)

@asottile
Copy link
Contributor

This has different semantics. In python2 string_types is (unicode, bytes) in python3 it is just (str,) -- not sure if that matters in this case but it is the reason that I left it as two separate conditionals.

@obestwalter
Copy link
Member Author

The check only looks if it is some kind of string or a an iterable containing name and version, so that simple test is sufficient.

Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet -- shipit!

@obestwalter obestwalter merged commit ae607d0 into tox-dev:master Sep 10, 2017
@obestwalter obestwalter deleted the use-string_types-check branch April 13, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants