cmd simplify, use pytest stderr/stdout management, and use regex instead of fnmatch #711
Conversation
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 94.6% 94.61% +0.01%
==========================================
Files 11 11
Lines 2426 2377 -49
==========================================
- Hits 2295 2249 -46
+ Misses 131 128 -3
Continue to review full report at Codecov.
|
tests/conftest.py
Outdated
| @@ -1 +1,2 @@ | |||
| # noinspection PyUnresolvedReferences | |||
| from tox._pytestplugin import * # noqa | |||
There was a problem hiding this comment.
please replace this with pytest_plugins = ['tox._pytestplugin']
| @@ -34,10 +34,12 @@ def prepare(args): | |||
| return config | |||
|
|
|||
|
|
|||
| def main(args=None): | |||
| def main(args): | |||
There was a problem hiding this comment.
This change breaks the tox startup executable set up by setuptools. When that startup executable runs tox's main() function (and this is the one used), it does not pass it any arguments.
There was a problem hiding this comment.
@gaborbernat - And we might want to add an external process test making sure those setuptools installed starter executables work correctly in the future?
| (','.join(["'%s'" % m for m in venv.envconfig.missing_subs]))) | ||
| "unresolvable substitution(s): %s. " | ||
| "Environment variables are missing or defined recursively." % | ||
| (','.join(["'%s'" % m for m in venv.envconfig.missing_subs]))) |
There was a problem hiding this comment.
Why do we do an extra level of indentation is such cases?
this is #660, but for some reason that did not get merged 🙅