Skip to content

Conversation

devmotion
Copy link
Collaborator

Fixes a deprecation warning by switching to the new form of the constructor and the type parameter of ADTypes.AutoReverseDiff introduced in ADTypes 1.5.

Ref TuringLang/Turing.jl#2302

Copy link
Owner

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tpapp tpapp self-requested a review August 13, 2024 11:01
tpapp
tpapp previously approved these changes Aug 13, 2024
Copy link
Owner

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Test failure seems to be unrelated.

@tpapp
Copy link
Owner

tpapp commented Aug 13, 2024

I think the failure is unrelated, but we should fix that before making another release.

Copy link
Owner

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants