Support assignment for non_null_assertion in the LHS #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! I left a question about tree-sitter/tree-sitter-javascript#146. Let's resolve that before merging this one. |
resolritter
added a commit
to resolritter/tree-sitter-javascript
that referenced
this pull request
Dec 2, 2020
resolritter
force-pushed
the
non_null_assertion_assignment
branch
2 times, most recently
from
fd7ec0e to
e68a521
Compare
maxbrunsfeld
pushed a commit
to tree-sitter/tree-sitter-javascript
that referenced
this pull request
Dec 2, 2020
* designate special group for LHS of augmented assignment expression needed for tree-sitter/tree-sitter-typescript#119 * regenerate parser for '_augmented_assignment_lhs' Co-authored-by: resolritter <[email protected]>
maxbrunsfeld
reviewed
Dec 2, 2020
common/define-grammar.js
Outdated
| )), | ||
|
|
||
| _augmented_assignment_lhs: ($, previous) => choice(...previous.members.concat([$.non_null_expression])), | ||
| _lhs_expression: ($, previous) => choice(...previous.members.concat([$.non_null_expression])), |
There was a problem hiding this comment.
I think both of these could be written choice(previous, $.non_null_expression). The nesting of choices doesn't matter, so there's no need to 'flatten' it out.
There was a problem hiding this comment.
Suggestion taken
resolritter
force-pushed
the
non_null_assertion_assignment
branch
from
e68a521 to
e33f458
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #107
Code changes are ready. The PR is currently marked as "Draft" because it requires changes in tree-sitter-javascript (tree-sitter/tree-sitter-javascript#146).