Only schedule FTE task if it received non-replicated splits #17790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhimondr
approved these changes
Jun 7, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
linzebing
force-pushed
the
schedule-when-received-split
branch
from
795423d to
6c954bd
Compare
linzebing
changed the title
linzebing
force-pushed
the
schedule-when-received-split
branch
from
8102efe to
5251d10
Compare
arhimondr
reviewed
Jun 7, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
linzebing
force-pushed
the
schedule-when-received-split
branch
from
5251d10 to
7621870
Compare
linzebing
changed the title
linzebing
changed the title
linzebing
changed the title
linzebing
force-pushed
the
schedule-when-received-split
branch
2 times, most recently
from
16ed103 to
e7db557
Compare
arhimondr
approved these changes
Jun 7, 2023
linzebing
force-pushed
the
schedule-when-received-split
branch
from
e7db557 to
8b3fdfc
Compare
losipiuk
reviewed
Jun 8, 2023
There was a problem hiding this comment.
This is not a great name; at this point task is not scheduled, just merly put in the scheduling queue for scheduling late. Let's keep for now as it at least is in-line with PrioritizedScheduledTask
There was a problem hiding this comment.
Yeah I was using taskCreated, but @arhimondr suggested to change to taskScheduled:)
losipiuk
reviewed
Jun 8, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jun 8, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jun 8, 2023
losipiuk
reviewed
Jun 8, 2023
losipiuk
reviewed
Jun 8, 2023
linzebing
force-pushed
the
schedule-when-received-split
branch
from
8b3fdfc to
4a518f0
Compare
losipiuk
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now we create all tasks upfront and we schedule them immediately. This PR changes to only schedule a task when it has actually received non-replicated splits
Additional context and related issues
#17596
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: