Skip to content

Conversation

findinpath
Copy link
Contributor

@findinpath findinpath commented Jun 14, 2023

Description

Make sure that Delta tables restored to a previous version are read accurately via Trino.

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jun 14, 2023
@findinpath findinpath self-assigned this Jun 14, 2023
@findinpath findinpath added no-release-notes This pull request does not require release notes entry delta-lake Delta Lake connector labels Jun 14, 2023
@findinpath findinpath requested review from findepi, ebyhr and pajaks June 14, 2023 15:50
@findinpath findinpath force-pushed the findinpath/delta-restore-test branch from 9c150de to e532bfb Compare June 15, 2023 04:11
@findinpath findinpath requested a review from ebyhr June 15, 2023 08:01
@ebyhr
Copy link
Member

ebyhr commented Jun 15, 2023

/test-with-secrets sha=e532bfb302416943ae5ee6d75113998b639123ce

@github-actions
Copy link

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5277101455

@findinpath
Copy link
Contributor Author

 Caused by: java.sql.SQLException: [Databricks][DatabricksJDBCDriver](500051) ERROR processing query/statement. Error Code: 0, SQL state: Error running query: org.apache.spark.sql.catalyst.parser.ParseException: 
2023-06-15T12:15:54.8594794Z tests               | extraneous input 'RESTORE' expecting {'(', 'CONVERT', 'COPY', 'OPTIMIZE', 'ADD', 'ALTER', 'ANALYZE', 'CACHE', 'CLEAR', 'COMMENT', 'COMMIT', 'CREATE', 'DELETE', 'DESC', 'DESCRIBE', 'DFS', 'DROP', 'EXPLAIN', 'EXPORT', 'FROM', 'GRANT', 'IMPORT', 'INSERT', 'LIST', 'LOAD', 'LOCK', 'MAP', 'MERGE', 'MSCK', 'REDUCE', 'REFRESH', 'REPLACE', 'RESET', 'REVOKE', 'ROLLBACK', 'SELECT', 'SET', 'SHOW', 'START', 'TABLE', 'TRUNCATE', 'UNCACHE', 'UNLOCK', 'UPDATE', 'USE', 'VALUES', 'WITH'}(line 1, pos 0)
2023-06-15T12:15:54.8623210Z tests               | 
2023-06-15T12:15:54.8623710Z tests               | == SQL ==
2023-06-15T12:15:54.8624242Z tests               | RESTORE TABLE default.test_dl_time_travel_restore_kc6009473a TO VERSION AS OF 1

in suite delta-lake-databricks-73 - excluding the test case for this cluster version.

@findinpath findinpath force-pushed the findinpath/delta-restore-test branch from e532bfb to b2a41b5 Compare June 15, 2023 19:49
@findinpath
Copy link
Contributor Author

@ebyhr please run this PR again with secrets.

@ebyhr
Copy link
Member

ebyhr commented Jun 16, 2023

/test-with-secrets sha=b2a41b512559191a4087ab8fd52741544f2b1239

https://github.com/trinodb/trino/actions/runs/5286856101

@ebyhr ebyhr merged commit 95eb18b into trinodb:master Jun 16, 2023
@github-actions github-actions bot added this to the 420 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants