-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Don't retry table metadata read when fails with ValidationException #17905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f2e8fe0
to
a32ea5d
Compare
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
a32ea5d
to
7b18ab6
Compare
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trino/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java
Lines 533 to 536 in 2dc0342
// try to drop table | |
assertUpdate("DROP TABLE " + tableName); | |
assertFalse(getQueryRunner().tableExists(getSession(), tableName)); | |
assertFalse(fileSystem.listFiles(tableLocation).hasNext(), "Table location should not exist"); |
Do you happen to remember why we've added the test for the situation on the smoke test and not on BaseIcebergConnectorTest ?
I'm not necessarily requesting the checks to be done here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are also added in BaseIcebergConnectorTest
.
trino/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Line 6634 in 2dc0342
public void testDropTableWithMissingSnapshotFile() |
We wanted to verify the corrupted table against all catalogs and smoke test runs against all catalogs so added smoke test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more reason to add smoke connector test is to verify against the different file systems.
7b18ab6
to
37a5b97
Compare
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
37a5b97
to
0a2022a
Compare
Thank you @findepi for the review. Addressed comments. |
Description
Don't retry table metadata read when fails with ValidationException