-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update AWS SDK v2 to 2.20.89 #17989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AWS SDK v2 to 2.20.89 #17989
Conversation
@trinodb/maintainers pls run the PR with secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was here for a reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @linzebing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now when you changed fromByteBufferUnsafe
it should be fine.
@linzebing PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore ByteBufferAsyncRequestBody.
BTW: Even if we wanted to drop it - it should be separate commit - not SDK version update
It was introduced in aws/aws-sdk-java-v2#3925 (https://github.com/aws/aws-sdk-java-v2/releases/tag/2.20.84) |
485901d
to
4776e1d
Compare
@losipiuk extracted to separate commit |
@losipiuk I think this part is relevant:
|
There is also pending PR which seems relevant here: aws/aws-sdk-java-v2#4096:
|
It was introduced in SDK v2 2.20.84 by aws/aws-sdk-java-v2#3925
4776e1d
to
87e9678
Compare
/test-with-secrets 7d308de |
/test-with-secrets sha=7d308deed56c6cc619d16b1b7a18a7713972e586 |
Looks like we need to squash the commits, since the |
No description provided.