Skip to content

Remove uuidv5 generation for xcresult #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove uuidv5 generation for xcresult #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion xcresult/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ log = "0.4.22"
quick-junit = "0.5.0"
regex = "1.11.0"
serde_json = "1.0.133"
uuid = { version = "1.10.0", features = ["v5"] }

[dev-dependencies]
flate2 = "1.0.34"
Expand Down
13 changes: 1 addition & 12 deletions xcresult/src/xcresult.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,7 @@ impl XCResult {
}

fn generate_id(&self, raw_id: &str) -> String {
// join the org and repo name to the raw id and generate uuid v5 from it
return uuid::Uuid::new_v5(
&uuid::Uuid::NAMESPACE_URL,
format!(
"{}#{}#{}",
self.org_url_slug,
&self.repo_url_parts.repo_full_name(),
raw_id
)
.as_bytes(),
)
.to_string();
format!("trunk:{}", raw_id)
}

fn junit_testcase(
Expand Down
108 changes: 54 additions & 54 deletions xcresult/tests/data/test-ExpectedFailures.junit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,136 +1,136 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="xcresult" tests="52" failures="25" errors="0" time="225.926">
<testsuite name="AtomicBoyTests.xctest" tests="2" disabled="0" errors="0" failures="1" time="0.288" id="96fc0ef6-d4fc-5ae8-acc8-bfd014e640f2">
<testcase name="testExample" classname="AtomicBoyTests" time="0.019" id="f3c6a49d-9fc4-553e-9a6e-ff1173356ef9">
<testsuite name="AtomicBoyTests.xctest" tests="2" disabled="0" errors="0" failures="1" time="0.288" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyTests/AtomicBoyTests.xctest">
<testcase name="testExample" classname="AtomicBoyTests" time="0.019" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyTests/AtomicBoyTests/testExample">
<failure/>
</testcase>
<testcase name="testPerformanceExample" classname="AtomicBoyTests" time="0.266" id="60b936c4-e160-5f02-938f-005b9e710a46">
<testcase name="testPerformanceExample" classname="AtomicBoyTests" time="0.266" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyTests/AtomicBoyTests/testPerformanceExample">
</testcase>
</testsuite>
<testsuite name="AtomicBoyUITests.xctest" tests="50" disabled="0" errors="0" failures="24" time="218.000" id="7e4bef0d-3ce5-5d44-b7ad-eed7fa4555a0">
<testcase name="testExample" classname="AtomicBoyUITests" time="3.311" id="d783b0f0-6ecd-5a1b-9903-5e925a92b208">
<testsuite name="AtomicBoyUITests.xctest" tests="50" disabled="0" errors="0" failures="24" time="218.000" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests.xctest">
<testcase name="testExample" classname="AtomicBoyUITests" time="3.311" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample">
<failure/>
</testcase>
<testcase name="testExample10" classname="AtomicBoyUITests" time="4.465" id="fb99da41-c379-53e8-a836-87db18e3a9e1">
<testcase name="testExample10" classname="AtomicBoyUITests" time="4.465" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample10">
</testcase>
<testcase name="testExample11" classname="AtomicBoyUITests" time="4.390" id="3896eff0-c0fd-5b34-ad4f-34b9d4837387">
<testcase name="testExample11" classname="AtomicBoyUITests" time="4.390" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample11">
<failure/>
</testcase>
<testcase name="testExample12" classname="AtomicBoyUITests" time="4.663" id="6ad18147-0e71-570d-b4b8-486cfe62557f">
<testcase name="testExample12" classname="AtomicBoyUITests" time="4.663" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample12">
<failure/>
</testcase>
<testcase name="testExample13" classname="AtomicBoyUITests" time="4.970" id="9ce8640a-ba66-5cc4-9595-51d8d3161382">
<testcase name="testExample13" classname="AtomicBoyUITests" time="4.970" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample13">
<failure/>
</testcase>
<testcase name="testExample14" classname="AtomicBoyUITests" time="4.196" id="2b6484f2-97e0-5d7a-8d84-8627a5200972">
<testcase name="testExample14" classname="AtomicBoyUITests" time="4.196" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample14">
<failure/>
</testcase>
<testcase name="testExample15" classname="AtomicBoyUITests" time="4.396" id="9e67048d-4288-52f9-9436-28c74fe54a02">
<testcase name="testExample15" classname="AtomicBoyUITests" time="4.396" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample15">
<failure/>
</testcase>
<testcase name="testExample16" classname="AtomicBoyUITests" time="4.358" id="fd99a621-4b56-5a0c-b71b-2bd007eee9bf">
<testcase name="testExample16" classname="AtomicBoyUITests" time="4.358" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample16">
<failure/>
</testcase>
<testcase name="testExample17" classname="AtomicBoyUITests" time="4.671" id="6964be8e-a09c-5da2-b6fc-383322e43d7d">
<testcase name="testExample17" classname="AtomicBoyUITests" time="4.671" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample17">
</testcase>
<testcase name="testExample18" classname="AtomicBoyUITests" time="4.432" id="2e8c7854-1640-5344-94e1-a7deb802741d">
<testcase name="testExample18" classname="AtomicBoyUITests" time="4.432" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample18">
</testcase>
<testcase name="testExample19" classname="AtomicBoyUITests" time="4.634" id="e08852b8-65b1-58b4-bdb2-1301075956b2">
<testcase name="testExample19" classname="AtomicBoyUITests" time="4.634" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample19">
<failure/>
</testcase>
<testcase name="testExample2" classname="AtomicBoyUITests" time="4.899" id="5e65f2c2-0c7e-5002-8b96-d1e64c0152ff">
<testcase name="testExample2" classname="AtomicBoyUITests" time="4.899" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample2">
<failure/>
</testcase>
<testcase name="testExample20" classname="AtomicBoyUITests" time="5.088" id="66012218-9934-5fab-9538-e0d17a992857">
<testcase name="testExample20" classname="AtomicBoyUITests" time="5.088" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample20">
</testcase>
<testcase name="testExample21" classname="AtomicBoyUITests" time="4.507" id="0201ae82-874c-5382-a5f0-e979784ee0f7">
<testcase name="testExample21" classname="AtomicBoyUITests" time="4.507" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample21">
<failure/>
</testcase>
<testcase name="testExample22" classname="AtomicBoyUITests" time="4.250" id="cc5a84dc-40ec-5d38-892b-75e4b670b696">
<testcase name="testExample22" classname="AtomicBoyUITests" time="4.250" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample22">
<failure/>
</testcase>
<testcase name="testExample23" classname="AtomicBoyUITests" time="4.287" id="f591f46d-6e94-5dc3-af05-e2e77a13cb69">
<testcase name="testExample23" classname="AtomicBoyUITests" time="4.287" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample23">
<failure/>
</testcase>
<testcase name="testExample24" classname="AtomicBoyUITests" time="4.515" id="58be5c15-1ad7-515e-840e-2040bc1c2548">
<testcase name="testExample24" classname="AtomicBoyUITests" time="4.515" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample24">
<failure/>
</testcase>
<testcase name="testExample25" classname="AtomicBoyUITests" time="4.380" id="7cf6ccf9-19aa-5056-a39b-80d36539ecda">
<testcase name="testExample25" classname="AtomicBoyUITests" time="4.380" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample25">
</testcase>
<testcase name="testExample26" classname="AtomicBoyUITests" time="4.389" id="46fdfeaf-e3ea-5798-b179-c3a4c4017728">
<testcase name="testExample26" classname="AtomicBoyUITests" time="4.389" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample26">
</testcase>
<testcase name="testExample27" classname="AtomicBoyUITests" time="4.528" id="c44bd583-6845-5a8e-b3ef-2e0adeee98c1">
<testcase name="testExample27" classname="AtomicBoyUITests" time="4.528" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample27">
<failure/>
</testcase>
<testcase name="testExample28" classname="AtomicBoyUITests" time="4.280" id="a0eee77e-99eb-5d5f-b31d-7980556af034">
<testcase name="testExample28" classname="AtomicBoyUITests" time="4.280" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample28">
<failure/>
</testcase>
<testcase name="testExample29" classname="AtomicBoyUITests" time="5.109" id="39decc16-5d3a-51b1-8a21-6281e1c9a13c">
<testcase name="testExample29" classname="AtomicBoyUITests" time="5.109" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample29">
<failure/>
</testcase>
<testcase name="testExample3" classname="AtomicBoyUITests" time="4.605" id="b7dfa4a2-4d6a-5efa-b80b-2e8a5ba7542b">
<testcase name="testExample3" classname="AtomicBoyUITests" time="4.605" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample3">
</testcase>
<testcase name="testExample30" classname="AtomicBoyUITests" time="4.830" id="86a6d280-4c48-5ffa-9bb9-b002946314f7">
<testcase name="testExample30" classname="AtomicBoyUITests" time="4.830" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample30">
<failure/>
</testcase>
<testcase name="testExample31" classname="AtomicBoyUITests" time="4.042" id="9789a1fb-1e74-5705-91ab-82b96038c769">
<testcase name="testExample31" classname="AtomicBoyUITests" time="4.042" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample31">
</testcase>
<testcase name="testExample32" classname="AtomicBoyUITests" time="4.020" id="d593fbc6-6f81-5742-876d-b1357b4c5f16">
<testcase name="testExample32" classname="AtomicBoyUITests" time="4.020" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample32">
</testcase>
<testcase name="testExample33" classname="AtomicBoyUITests" time="4.043" id="67510001-ae30-5300-9a9c-7c435d77f977">
<testcase name="testExample33" classname="AtomicBoyUITests" time="4.043" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample33">
</testcase>
<testcase name="testExample34" classname="AtomicBoyUITests" time="4.046" id="fe2be23d-c239-56d9-81b2-c155c983bc3a">
<testcase name="testExample34" classname="AtomicBoyUITests" time="4.046" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample34">
</testcase>
<testcase name="testExample35" classname="AtomicBoyUITests" time="4.242" id="1deffb9f-4a23-5795-a771-bebbb30c130e">
<testcase name="testExample35" classname="AtomicBoyUITests" time="4.242" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample35">
<failure/>
</testcase>
<testcase name="testExample36" classname="AtomicBoyUITests" time="4.155" id="a1b54dc5-7bbd-5463-9579-cd240f626872">
<testcase name="testExample36" classname="AtomicBoyUITests" time="4.155" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample36">
</testcase>
<testcase name="testExample37" classname="AtomicBoyUITests" time="5.152" id="15372cb0-d79d-5f01-9d35-b434e93c681f">
<testcase name="testExample37" classname="AtomicBoyUITests" time="5.152" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample37">
<failure/>
</testcase>
<testcase name="testExample38" classname="AtomicBoyUITests" time="4.510" id="b2a0347a-8618-57ad-857a-401059bef837">
<testcase name="testExample38" classname="AtomicBoyUITests" time="4.510" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample38">
<failure/>
</testcase>
<testcase name="testExample39" classname="AtomicBoyUITests" time="4.334" id="1f7dbb08-9f2d-5cad-883d-d31818823a3f">
<testcase name="testExample39" classname="AtomicBoyUITests" time="4.334" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample39">
</testcase>
<testcase name="testExample4" classname="AtomicBoyUITests" time="4.353" id="bb2af780-222c-5d2c-8958-76e88e64fbb8">
<testcase name="testExample4" classname="AtomicBoyUITests" time="4.353" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample4">
</testcase>
<testcase name="testExample40" classname="AtomicBoyUITests" time="4.338" id="c30a43e9-0e94-5271-937f-78b6a0ad0bb5">
<testcase name="testExample40" classname="AtomicBoyUITests" time="4.338" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample40">
<failure/>
</testcase>
<testcase name="testExample41" classname="AtomicBoyUITests" time="4.431" id="c58e441b-336d-5633-a150-2e8e44aafdaa">
<testcase name="testExample41" classname="AtomicBoyUITests" time="4.431" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample41">
</testcase>
<testcase name="testExample42" classname="AtomicBoyUITests" time="4.823" id="aed472b8-b558-5291-83ea-08c8b2d0f487">
<testcase name="testExample42" classname="AtomicBoyUITests" time="4.823" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample42">
</testcase>
<testcase name="testExample43" classname="AtomicBoyUITests" time="4.258" id="6bf75b33-47b4-5a9a-8467-1c45814fbec8">
<testcase name="testExample43" classname="AtomicBoyUITests" time="4.258" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample43">
</testcase>
<testcase name="testExample44" classname="AtomicBoyUITests" time="4.652" id="5135a656-02a1-56a7-a7b0-62e792938828">
<testcase name="testExample44" classname="AtomicBoyUITests" time="4.652" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample44">
</testcase>
<testcase name="testExample45" classname="AtomicBoyUITests" time="4.122" id="45d8885e-f401-5964-b949-ed73cb4e0c77">
<testcase name="testExample45" classname="AtomicBoyUITests" time="4.122" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample45">
</testcase>
<testcase name="testExample46" classname="AtomicBoyUITests" time="4.313" id="a909baac-3962-5bbe-a1df-622d236fba9c">
<testcase name="testExample46" classname="AtomicBoyUITests" time="4.313" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample46">
</testcase>
<testcase name="testExample47" classname="AtomicBoyUITests" time="4.302" id="0a9a7d35-feef-5447-a983-2d26aadaa71f">
<testcase name="testExample47" classname="AtomicBoyUITests" time="4.302" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample47">
</testcase>
<testcase name="testExample48" classname="AtomicBoyUITests" time="5.178" id="2ed094dd-7b01-520f-922a-0d580e515fec">
<testcase name="testExample48" classname="AtomicBoyUITests" time="5.178" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample48">
<failure/>
</testcase>
<testcase name="testExample5" classname="AtomicBoyUITests" time="4.381" id="b4747c60-0af2-5f66-913a-186fa0d3a36d">
<testcase name="testExample5" classname="AtomicBoyUITests" time="4.381" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample5">
<failure/>
</testcase>
<testcase name="testExample6" classname="AtomicBoyUITests" time="4.420" id="2203f4dc-3f7b-5c0e-a3df-3b821bd2c078">
<testcase name="testExample6" classname="AtomicBoyUITests" time="4.420" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample6">
</testcase>
<testcase name="testExample7" classname="AtomicBoyUITests" time="4.383" id="cbdf63a0-ce3e-588b-ab0f-fff1d71510c7">
<testcase name="testExample7" classname="AtomicBoyUITests" time="4.383" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample7">
</testcase>
<testcase name="testExample8" classname="AtomicBoyUITests" time="4.263" id="71c9f4f6-8f13-5cfa-b4c3-2036c58bb0b6">
<testcase name="testExample8" classname="AtomicBoyUITests" time="4.263" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample8">
</testcase>
<testcase name="testExample9" classname="AtomicBoyUITests" time="4.616" id="0a0a59ce-9435-5311-a6a9-adf5ae8f3563">
<testcase name="testExample9" classname="AtomicBoyUITests" time="4.616" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/AtomicBoyUITests/testExample9">
<failure/>
</testcase>
<testcase name="testExample()" classname="CobaltDog" time="4.388" id="bfc3435b-d86d-5a31-83e6-8122341befcc">
<testcase name="testExample()" classname="CobaltDog" time="4.388" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/CobaltDog/testExample">
</testcase>
<testcase name="testExample()" classname="SwiftAtomicBoyUITests" time="0.017" id="0475623c-64a2-5805-b3ec-f1cbdc675753">
<testcase name="testExample()" classname="SwiftAtomicBoyUITests" time="0.017" id="trunk:test://com.apple.xcode/AtomicBoy/AtomicBoyUITests/SwiftAtomicBoyUITests/testExample">
</testcase>
</testsuite>
</testsuites>
Loading