fix: improve workspace detection for workspace members #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes workspace detection when running trunk from within workspace member directories. Previously, trunk would fail to detect the correct package when run from a workspace member directory, now it properly handles both standalone packages and workspace scenarios.
Fixes: #909
Related: #719
Problem
The original `CargoMetadata::new()` method only used `metadata.root_package()` which works for standalone packages but fails for workspace members. When running trunk from within a workspace member directory (e.g., `my-workspace/frontend/`), trunk would fail with "could not find the root package of the target crate".
Solution
Enhanced the workspace detection logic to:
Changes
Testing & Validation
Manual Testing
Expected Results
Before the fix:
After the fix:
Backward Compatibility
✅ Fully backward compatible - standalone packages continue to work exactly as before via the `root_package()` path.
Additional Notes
Terminal