Compatibility and tutorial fixes #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wardsimon
commented
Jan 19, 2018
wardsimon
commented
- Fixed functions not present in Matlab version < R2017a
- Fixed so that all tutorials run
- Fixed some aspects of symbolic calculation
Redoing the Horace interface to SpinW
More Horace integration
Update develeopment
chol_omp, eig_omp and sw_mtimes compiled under R2017b using OSX 10.13.6
Allow to turn off legends in plot mode 4
An additional transformation in `+swplot/patchfacefcn.m` is needed in post R2017b. Thanks go to @Fellow-baka for finding it :-)
Bug Fixes
sw_update will now check github releases and pull the latest release. Fix in reference to issue #25
Also use same method to cut data in plotting 1D cuts of 2D data as when replacing data with 1D cuts. Updated tests
Now pfit and SigP have same shape
This is done so that there is always an E0 label regardless of background strategy
Fix bugs identified by user
This is only valid in some cases
…powder Fix bug in scale factor estimation Add new function to fit bg and scale to all data (fixing model) Support any ndbase optimizer in fit_background Add methods to set and clear background region Add method to plot background region Initialise background parameters with sensible values when switching background strategy Handle edges/nans properly in avg. of error when taking 1D cuts Support general polynomial background in Q and en Use 2D data Q bins when replace with 1D cuts (previously just used nQ bins between qmin and qmax) Update tutorial Add method to export data into structs (or array of structs for 1D) - for fitbenchmarking Add ability to set background parameters, bounds etc. by string label Add method to print parameters nicely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.