Skip to content

refactor population table storage #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

molpopgen
Copy link
Member

  • refactor pop table to store pointer
  • change storage to const ptr, various fixes
  • Sneak in design of owning table.
  • Passes if we do this:

@molpopgen
Copy link
Member Author

As far as #262 goes:

  1. We have to remove lifetime annotation from tables
    and replace held reference with pointer.
  2. We have to break API of TableAccess, returning
    &FooTable instead of FooTable<'a>.
    This change will not break any code using
    current implementers.
    Rather, it only breaks API for those
    implementing it, which is realistically
    no-one right now.
  3. We almost certainly need FooTable to
    know if they own their pointers or not.

The best plan would be to do 1 and 2 in a PR.
Then stack a PR on top to do 3.
Finally, we can take a shot at #262.

@molpopgen
Copy link
Member Author

Update to the previous:

It probably makes sense to abstract out item 3
before tackling 1 and 2.

@molpopgen
Copy link
Member Author

We have found a way out of needing an "owning" abstraction:

The new table types contain both MBox and the refactored table type.

@molpopgen
Copy link
Member Author

closing -- see comments in #262

@molpopgen molpopgen closed this Jul 18, 2022
@molpopgen molpopgen deleted the refactor_population_table_storage branch August 21, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant