remove table struct lifetimes #266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
commented
Jul 18, 2022
molpopgen
commented
Jul 18, 2022
src/table_collection.rs
Outdated
| pub struct TableCollection { | ||
| pub(crate) inner: MBox<ll_bindings::tsk_table_collection_t>, | ||
| populations: PopulationTable, |
There was a problem hiding this comment.
This logic is repeating in TreeSequence. We need a new struct to abstract this out.
|
Closing -- see #262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table types are currently defined as
EdgeTable<'a>,where the lifetime is that of the table collection
owning the tables.
We need to relax this lifetime bound in order to
support standalone tables.
This PR:
They now store
*constinstead of&'areferencesto the low-level table type.
TableCollection to store instances of the table
types.
TableAccessfunctionsto be
&Tableinstead ofTable.These changes will go into a new version number.
The last change is technically a break change:
client codes implementing the trait will have their
implementations break. However, I suspect no one has
done so.