remove table lifetime annotations #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
force-pushed
the
remove_table_lifetime_annotations
branch
from
3c36247 to
060c12d
Compare
* Types like EdgeTable no longer require lifetimes. * tskit::table_views::TableViews is now a Deref target of TableCollection and TreeSequence. * This Deref target replaces the behaviors of the TableAccess and NodeListGenerator traits, which have been removed. * TableViews is a DerefMut target of TableCollection. * The removed traits affect the contents of the crate prelude. * Some code that would not compile due to dropped temporaries will now compile. (Doc tests updated accordingly.) * The new fn nodes_mut addresses API breakage. These changes are a BIG WIN for overall design. BREAKING CHANGE: traits replaced with Deref targets
molpopgen
force-pushed
the
remove_table_lifetime_annotations
branch
from
ada5e08 to
d09ae95
Compare
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WIP to remove lifetime annotations from all table types
and replace with
NonNullinstead.