Skip to content

Refine table column design #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

molpopgen
Copy link
Member

No description provided.

@molpopgen molpopgen marked this pull request as draft May 20, 2025 21:07
@molpopgen
Copy link
Member Author

molpopgen commented May 20, 2025

TODO:

  • Move the trait into src/traits.rs
  • Add the trait to the prelude
  • Add fns for the rest of the table types.

@molpopgen
Copy link
Member Author

We need to ignore the TODO list above -- it turns out that many/most tables don't even have the slice accessors in place. Those that do are doing it with unsafe code that we can easily push back into the sys module. But all of that should be in a later PR.

replaces concrete types added in #726, #730
@molpopgen molpopgen force-pushed the non_ragged_table_column branch from 5dc109c to 7f3e060 Compare May 22, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant