Skip to content

Rename tree_height_scale to time_scale? #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeromekelleher opened this issue Mar 22, 2021 · 1 comment · Fixed by #1331
Closed

Rename tree_height_scale to time_scale? #1262

jeromekelleher opened this issue Mar 22, 2021 · 1 comment · Fixed by #1331
Labels
Python API Issue is about the Python API Visualisation This issue addresses visualisation
Milestone
Python 0.3.6

Comments

@jeromekelleher
Copy link
Member

jeromekelleher commented Mar 22, 2021 •
edited
Loading

I had to look the docs up for this just now - it would be more obvious to have e.g. time_scale="rank" rather than tree_height_scale="rank". Not sure if there's any good reason for what it is currently?

We'd keep tree_height_scale as a deprecated synonym.

@hyanwong, thoughts?
@jeromekelleher jeromekelleher added Python API Issue is about the Python API Visualisation This issue addresses visualisation labels Mar 22, 2021
@hyanwong
Copy link
Member

time_scale seems fine to me. I can't remember what rationale (if any) there was behind tree_height_scale.

@jeromekelleher jeromekelleher added this to the Python 0.3.6 milestone Mar 22, 2021
@benjeffery benjeffery mentioned this issue Apr 27, 2021
Merged
@mergify mergify bot closed this as completed in #1331 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Python API Issue is about the Python API Visualisation This issue addresses visualisation
Projects
None yet
Milestone
Python 0.3.6
Development

Successfully merging a pull request may close this issue.

Rename tree height to time benjeffery/tskit
2 participants
@jeromekelleher @hyanwong