Skip to content

Rename tree height to time #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

benjeffery
Copy link
Member

Fixes #1262

@benjeffery benjeffery requested a review from hyanwong April 27, 2021 13:04
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1331 (5340502) into main (495f8df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   93.83%   93.84%           
=======================================
  Files          26       26           
  Lines       22344    22363   +19     
  Branches     1060     1066    +6     
=======================================
+ Hits        20967    20986   +19     
  Misses       1343     1343           
  Partials       34       34           
Flag Coverage Δ
c-tests 92.41% <ø> (ø)
lwt-tests 92.97% <ø> (ø)
python-c-tests 95.20% <100.00%> (+<0.01%) ⬆️
python-tests 98.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 97.93% <ø> (ø)
python/tskit/drawing.py 99.50% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495f8df...5340502. Read the comment docs.

Copy link
Member

@hyanwong hyanwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benjeffery benjeffery force-pushed the rename-tree-height branch 2 times, most recently from 4ad5369 to e179edc Compare May 6, 2021 13:07
@benjeffery benjeffery force-pushed the rename-tree-height branch from e179edc to 5340502 Compare May 6, 2021 13:29
@mergify mergify bot merged commit 2536909 into tskit-dev:main May 6, 2021
@benjeffery benjeffery deleted the rename-tree-height branch May 6, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename tree_height_scale to time_scale?
3 participants