Skip to content

Conversation

benjeffery
Copy link
Member

Closes #1135

I've been through quite closely to check for extra bits and pieces.

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1153 (b839c7a) into main (93a3fd8) will increase coverage by 0.08%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   93.65%   93.73%   +0.08%     
==========================================
  Files          26       26              
  Lines       21236    21254      +18     
  Branches      900      902       +2     
==========================================
+ Hits        19888    19922      +34     
+ Misses       1311     1294      -17     
- Partials       37       38       +1     
Flag Coverage Δ
c-tests 92.52% <ø> (+0.16%) ⬆️
lwt-tests 92.78% <ø> (ø)
python-c-tests 94.89% <94.73%> (-0.01%) ⬇️
python-tests 98.62% <94.73%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 97.42% <90.90%> (-0.05%) ⬇️
python/tskit/tables.py 99.60% <100.00%> (+<0.01%) ⬆️
python/tskit/util.py 100.00% <100.00%> (ø)
c/tskit/tables.c 90.81% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a3fd8...b839c7a. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for slogging through this one.

Just looks like we're missing a quick test for the text format?

@benjeffery
Copy link
Member Author

Looks great, thanks for slogging through this one.

Just looks like we're missing a quick test for the text format?

I've added #1175 as all the text parse methods need them, which seemed beyond this PR.

@AdminBot-tskit AdminBot-tskit force-pushed the individual-parents-the-return branch 2 times, most recently from d76cb41 to 021069a Compare February 1, 2021 12:31
@AdminBot-tskit AdminBot-tskit force-pushed the individual-parents-the-return branch from 021069a to b839c7a Compare February 1, 2021 13:10
@mergify mergify bot merged commit 88de511 into tskit-dev:main Feb 1, 2021
@benjeffery benjeffery deleted the individual-parents-the-return branch March 19, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests for Individual.parents

2 participants