Skip to content

Conversation

benjeffery
Copy link
Member

I looked into replacing Interval with a dataclass, but we iterate on it a lot, so left it as is. I thought it worth keeping these changes from [0] to .left.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1264 (ba708bd) into main (40159b6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   93.77%   93.77%   -0.01%     
==========================================
  Files          26       26              
  Lines       21940    21939       -1     
  Branches      971      971              
==========================================
- Hits        20574    20573       -1     
  Misses       1325     1325              
  Partials       41       41              
Flag Coverage Δ
c-tests 92.49% <ø> (ø)
lwt-tests 92.97% <ø> (ø)
python-c-tests 95.01% <100.00%> (-0.01%) ⬇️
python-tests 98.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/cli.py 96.26% <100.00%> (-0.03%) ⬇️
python/tskit/combinatorics.py 99.20% <100.00%> (ø)
python/tskit/trees.py 97.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40159b6...ba708bd. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement to readability, thanks.

We definitely do need to keep the tuple interpretation though.

@mergify mergify bot merged commit c84a89b into tskit-dev:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants