Improve string and html output #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 93.81% 93.80% -0.02%
==========================================
Files 26 26
Lines 22179 22143 -36
Branches 1006 1013 +7
==========================================
- Hits 20808 20772 -36
Misses 1338 1338
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
benjeffery
force-pushed
the
improve_str
branch
2 times, most recently
from
1cd8c2e to
2ac70d1
Compare
|
I've added |
There was a problem hiding this comment.
Do you think we could pick this one up and get it merged please @benjeffery? I'd like to use it in a presentation
python/tests/test_tables.py
Outdated
| input_data = self.make_input_data(41) | ||
| table = self.table_class() | ||
| table.set_columns(**input_data) | ||
| print(table) |
jeromekelleher
approved these changes
Apr 20, 2021
benjeffery
force-pushed
the
improve_str
branch
2 times, most recently
from
f5f0cbd to
ed75927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1270 by making
__str__for tables output unicode tables.Introduces
tskit.MAX_LINESwhich controls the number of lines to truncate the table to, in this way a user can see the whole of a table by setting it toNoneAlso displays decoded metadata instead of base64 encoding it, which also applies to HTML output. Metadata is truncated, to try to keep tables ~80 chars width. This is not controllable.
OLD:
NEW:
