-
Notifications
You must be signed in to change notification settings - Fork 77
Build wheels in github action #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good, thanks @benjeffery. We should probably verify that the oldest-numpy thing works over in kastore first before bringing this in, though? |
Yep, will sort that out over at kastore first. |
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 23 23
Lines 17687 17687
Branches 3498 3498
=======================================
Hits 15522 15522
Misses 1062 1062
Partials 1103 1103
Continue to review full report at Codecov.
|
@jeromekelleher Ready for review, getting testing working was a small fix in the end. Only needed change now is removing the triggering on PRs, but will do that when I squash so you can see the actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @benjeffery. I'm not that bothered about running the tests, but let's see how it works out. I suspect that the conda stuff will end up being a bit brittle, and this could let us down when it comes to tagging a release.
The full test are prob overkill, but the import test at least catches things like tskit-dev/msprime#1031 |
Mergify can't merge changes to github actions. |
Fixes #636