Skip to content

Build wheels in github action #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Conversation

benjeffery
Copy link
Member

@benjeffery benjeffery commented Jun 15, 2020

Fixes #636

@jeromekelleher
Copy link
Member

Looks good, thanks @benjeffery. We should probably verify that the oldest-numpy thing works over in kastore first before bringing this in, though?

@benjeffery
Copy link
Member Author

Yep, will sort that out over at kastore first.

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #681 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #681   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files          23       23           
  Lines       17687    17687           
  Branches     3498     3498           
=======================================
  Hits        15522    15522           
  Misses       1062     1062           
  Partials     1103     1103           
Flag Coverage Δ
#c_tests 89.03% <ø> (ø)
#python_c_tests 91.23% <ø> (ø)
#python_tests 98.99% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765e8ad...c30abcc. Read the comment docs.

@benjeffery benjeffery marked this pull request as ready for review June 22, 2020 14:35
@benjeffery
Copy link
Member Author

@jeromekelleher Ready for review, getting testing working was a small fix in the end. Only needed change now is removing the triggering on PRs, but will do that when I squash so you can see the actions.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @benjeffery. I'm not that bothered about running the tests, but let's see how it works out. I suspect that the conda stuff will end up being a bit brittle, and this could let us down when it comes to tagging a release.

@benjeffery
Copy link
Member Author

The full test are prob overkill, but the import test at least catches things like tskit-dev/msprime#1031
Squashed and PR trigger removed, marking for merge.

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Jun 22, 2020
@benjeffery
Copy link
Member Author

Mergify can't merge changes to github actions.

@benjeffery benjeffery merged commit 0e1521a into tskit-dev:master Jun 22, 2020
@benjeffery benjeffery deleted the wheels branch June 22, 2020 22:45
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated release infrastructure
2 participants