Skip to content

Set version for 0.3.0.beta1 release #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

benjeffery
Copy link
Member

No description provided.

@benjeffery benjeffery merged commit 2aca42c into tskit-dev:master Jul 29, 2020
@benjeffery benjeffery deleted the 0.3.0_prep branch July 29, 2020 13:50
@jeromekelleher
Copy link
Member

For PEP 440 version numbering this should be 0.3.0b1 rather than 0.3.0.b1. Setuptools will normalise to 0.3.0b1, so that there's a slight difference between the package version and the __version__ value:

>>> import tskit
>>> tskit.__version__
'0.3.0.b1'
>>> 

and the package is tskit-0.3.0b1.tar.gz (this is also the version string from pypi).

I don't think it'll make any difference for the beta though.

@benjeffery
Copy link
Member Author

I realised this at the time, but went with the convention specified in the comment in _version.py as setuptools was still happy.

@jeromekelleher
Copy link
Member

We should update the comment there to avoid confusion I think - 0.3.0.devN is correct for development releases but pre-releases have a different convention. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants