Skip to content

Refactor to use the dict representation of tree sequence #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromekelleher opened this issue Apr 8, 2021 · 2 comments · Fixed by #42
Closed

Refactor to use the dict representation of tree sequence #39

jeromekelleher opened this issue Apr 8, 2021 · 2 comments · Fixed by #42
Milestone

Comments

@jeromekelleher
Copy link
Member

Currently we're explicitly writing down the columns that we compress, leading to loss of data when we have format updates in tskit. We should use the dict representation of the tables instead, and automatically create Column objects for the data with good default compression options. We can make some special cases for particular columns if we like, but we should by default always store all the data that comes from the input tree sequence.

related to #35

@brianzhang01
Copy link
Member

If the format of written tsz files becomes different, it would be good to offer scripts to update old tsz files to this new format.

@jeromekelleher
Copy link
Member Author

We'll try to keep the same format if possible @brianzhang01, but if there's a different format needed we'll make sure the old ones are also transparently supported (so there's no need for format upgrades).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants