Skip to content

Compress top-level metadata #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Conversation

brianzhang01
Copy link
Member

I've been using the top-level metadata to store information related to the coordinates of my tree sequences (since tree sequences only have a sequence_length rather than a start / end position). It appears that this information is lost when compressing / decompressing using tszip. I believe this PR should resolve it; I'm also happy for things to get rewritten in a more sensible way.

@pep8speaks
Copy link

pep8speaks commented Apr 7, 2021

Hello @brianzhang01! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-07 21:48:57 UTC

@jeromekelleher
Copy link
Member

Looks good to me, thanks for the update @brianzhang01!

@benjeffery, I've made a few issues for us for the next release. I suggest we merge this PR, and then follow up with the more general solution in #39.

@jeromekelleher jeromekelleher added this to the Version 0.2.0 milestone Apr 8, 2021
@brianzhang01
Copy link
Member Author

Just checking in on the status of this PR. Thanks!

@jeromekelleher
Copy link
Member

Thanks @brianzhang01 - @benjeffery is on vacation at the moment, and I think we'll try to clear this up and push out a release of tszip fairly soon after he's back. I'd imagine we'll merge your PR as is, and then update from there.

@brianzhang01
Copy link
Member Author

Understood!

@benjeffery benjeffery merged commit 7d86c86 into tskit-dev:main Apr 19, 2021
@benjeffery
Copy link
Member

Thanks @brianzhang01! We'll give tszip a little TLC - thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants