Skip to content

Fix for time_units in tskit 0.4.1 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

benjeffery
Copy link
Member

Fixing #54 in a simpler way to #55 by hardcoding the property name.

@codecov-commenter
Copy link

Codecov Report

Merging #58 (57f154e) into main (55bc8c4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   97.70%   97.74%   +0.04%     
==========================================
  Files           6        6              
  Lines         305      311       +6     
  Branches       55       61       +6     
==========================================
+ Hits          298      304       +6     
  Misses          5        5              
  Partials        2        2              
Impacted Files Coverage Δ
tszip/cli.py 100.00% <100.00%> (ø)
tszip/compression.py 98.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb69791...57f154e. Read the comment docs.

@benjeffery
Copy link
Member Author

@jeromekelleher here's the quick fix. Will do a release after this is merged.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 73ef7e7 into tskit-dev:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants