Add support for reference sequences #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 97.70% 97.76% +0.05%
==========================================
Files 6 6
Lines 305 313 +8
Branches 55 62 +7
==========================================
+ Hits 298 306 +8
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
| # NOTE: it's unclear whether we'll want to have this set at the same time as | ||
| # 'data', but it's useful to have something in all columns for now. | ||
| tables.reference_sequence.url = "http://example.com/a_reference" | ||
| self.verify(tables.tree_sequence()) |
There was a problem hiding this comment.
I assume verify calls tables.assert_equals() somewhere along the line? Otherwise we won't actually be testing much here I think.
There was a problem hiding this comment.
I have verified that verify actually verifies. I changed to use assert_equals anyway as it gives better errors.
jeromekelleher
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It#s not very pretty, but that will have to wait for the refactor.