Skip to content

Error for more than one file with -c #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

aabiddanda
Copy link
Contributor

Addresses plan of action for #63. Main additions are:

  1. Error message if using -c flag for compression and more than one input file.
  2. Test to verify that error message is being thrown.

Comments & suggestions for error throwing/exiting messages are welcome (I opted for exit as its handled at the CLI-level).

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #64 (a54ac13) into main (73fe8a0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a54ac13 differs from pull request most recent head 95dd4ed. Consider uploading reports for the commit 95dd4ed to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   97.56%   97.58%   +0.01%     
==========================================
  Files           6        6              
  Lines         329      331       +2     
  Branches       65       66       +1     
==========================================
+ Hits          321      323       +2     
  Misses          6        6              
  Partials        2        2              
Impacted Files Coverage Δ
tszip/cli.py 99.06% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fe8a0...95dd4ed. Read the comment docs.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect @aabiddanda - as you say, we're doing this at the CLI level, so exit() is the right option.

If could update the CHANGELOG as well we can close #62 and we're ready to release I think.

@jeromekelleher jeromekelleher linked an issue Feb 21, 2022 that may be closed by this pull request
@aabiddanda
Copy link
Contributor Author

Awesome - this should have the changelog amended and the erroneous line removed. All boiled down to a nice squashed commit.

@jeromekelleher jeromekelleher linked an issue Feb 22, 2022 that may be closed by this pull request
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll ship the release immediately

@mergify mergify bot merged commit 5a5731d into tskit-dev:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle multiple input files with compressing to stdout Update changelog for 0.2.2
3 participants