-
Notifications
You must be signed in to change notification settings - Fork 61
Fixed request handling #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dayal-arnav05
commented
Sep 5, 2025
- Fixed bug with request closer. It no longer shuts down the server after tool so when making a second tool call before the server starts up again throws an error. Did this by changing server instance and lifecycle since we just have the server deployed anyway.
- Adjusted schema ranges so that it includes opportunity from 'today' when querying for something like 'last week'
- Fixed issue with request ID collisions with the async call.
- Added more info on the schema for the agent. Before responses were truncated at 500 characters, the agent couldn't see available fields, and added some better field errors
- Added some logging too
…AHSHHASHDHA SO MUCH LOGGING
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dayal-arnav05, @mnvsk97 👋
Thank you for taking the time to work on this PR and for the improvements to request handling - the changes look good and are heading in the right direction!
However, I'm encountering a runtime issue when testing the MCP server locally that's preventing me from fully evaluating the changes:
Error: failed to initialize server: failed to initialize client: transport error: server terminated.
Steps I followed:
Fetched the PR branch locally
Ran npm install and npm run build (both successful ✅)
Configured the MCP server in my Windsurf for testing:
"salesforce": {
"command": "node",
"args": ["local_path/mcp-server-salesforce/dist/index.js"],
"env": {
// ... environment variables
}
}
The server fails to initialize with the transport error above
This suggests there might be an issue with the server initialization or MCP protocol communication introduced in the request handling changes.
Could you please:
Test the server initialization in your MCP client setup
Verify that the MCP protocol handshake is working correctly
Check if there are any breaking changes to the server startup process
Ensure all MCP protocol methods are properly implemented
The build process works fine, so this appears to be a runtime/server initialization issue specifically.
Once this is resolved, I'd be happy to do a thorough review and test the request handling improvements!
Thanks again for your contribution to the project. Looking forward to the updated version!