This repository was archived by the owner on Apr 21, 2023. It is now read-only.
Horizontal legend spacing #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the |
mboorstin
suggested changes
Sep 19, 2016
| @@ -590,14 +591,14 @@ function computeLegendDimensions(gd, groups, traces) { | |||
| maxTraceWidth = 0, | |||
| offsetX = 0; | |||
|
|
|||
| // calculate largest width for traces and use for width of all legend items | |||
| // calculate largest width for traces and use for width of all legend items (if horizontalspacing mode is 'column') | |||
| traces.each(function(d) { | |||
There was a problem hiding this comment.
maxTraceWidth isn't used unless isHorizontalColumn is true, so don't compute it if not.
| traces.each(function(d) { | ||
| maxTraceWidth = Math.max(40 + d[0].width, maxTraceWidth); | ||
| }); | ||
|
|
||
| traces.each(function(d) { | ||
| var legendItem = d[0], | ||
| traceWidth = maxTraceWidth, | ||
| traceWidth = isHorizontalColumn ? maxTraceWidth : 40 + d[0].width, |
There was a problem hiding this comment.
Where is the 40 coming from? Leave a comment.
|
|
||
| exports.isHorizontalColumn = function isHorizontalColumn(legendLayout) { | ||
| return legendLayout.horizontalspacing === 'column'; | ||
| } |
| describe('isHorizontalColumn', function() { | ||
| var isHorizontalColumn = helpers.isHorizontalColumn; | ||
|
|
||
| it('should return true when option horizontalspacing is "column"', function() { |
There was a problem hiding this comment.
Break this into two tests: should return true when option horizontalspacing is "column", and should return false when option horizontalspacing is "wrapped"
| @@ -628,3 +637,54 @@ describe('legend restyle update', function() { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('legend horizontal spacing', function() { | |||
mboorstin
force-pushed
the
horizontal-legend-spacing
branch
from
e5836b4 to
8296b90
Compare
quickgiant
pushed a commit
that referenced
this pull request
Aug 16, 2019
* Fix bug in scattergl plot * Added tests for scattergl plot update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.