Skip to content

Fix faulty logic in Connection#transaction #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix faulty logic in Connection#transaction #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/libsql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ def transaction
abort = true
raise
ensure
abort and tx.rollback or tx.commit
abort ? tx.rollback : tx.commit
end
end

Expand Down
12 changes: 12 additions & 0 deletions spec/libsql_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,16 @@
expect(count).to eq(0)
end
end

describe 'Connection#transaction' do
context 'when there is an exception' do
it 'aborts the transaction and raises the exception' do
exception_class = Class.new(StandardError)

db.connect do |conn|
expect { conn.transaction { raise exception_class } }.to raise_error(exception_class)
end
end
end
end
end