Skip to content

mbed-tls-try2 updates #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 22, 2020
Merged

mbed-tls-try2 updates #3

merged 8 commits into from
Jan 22, 2020

Conversation

robert-alfaro
Copy link

@robert-alfaro robert-alfaro commented Jan 21, 2020 •
edited
Loading

  • merge upstream to branch
  • use sizeof instead of strlen for const char[]
  • add kconfig option to enable/disable ASYNC_TCP_SSL_ENABLED
    -- fix for cmake
  • optionally include ssl headers
  • add null check for pskey and psk_ident vars
  • don't default to PSK when root ca not explicitly provided

@robert-alfaro robert-alfaro requested a review from tve January 21, 2020 18:55
@robert-alfaro
Copy link
Author

robert-alfaro commented Jan 21, 2020 •
edited
Loading

@tve ok now we should be good. Can you try with these changes...like I said in the other PR, I'm still trying to get https working. Works now -- I was missing ECDHE-RSA in my config.

@robert-alfaro
Copy link
Author

Only issue I have is closing the connection or calling delete on the AsyncClient pointer. Do you have issues with closing/disconnects? fwiw, I recall having this problem before even using TLS changes.

tve
tve reviewed Jan 21, 2020
View reviewed changes
Copy link
Owner

@tve tve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I don't think this is ready yet, though...

@tve tve merged commit 44b3d6b into tve:mbed-tls-try2 Jan 22, 2020
@tve
Copy link
Owner

tve commented Jan 22, 2020

Great! Thanks!

@robert-alfaro robert-alfaro deleted the mbed-tls-try2 branch January 22, 2020 00:51
@robert-alfaro
Copy link
Author

Did you squash and merge? Preserving the commits with a rebase may have been better to keep history and easier merge for @me-no-dev

@robert-alfaro robert-alfaro restored the mbed-tls-try2 branch January 22, 2020 00:58
@tve
Copy link
Owner

tve commented Jan 22, 2020

Yes, I did squash, sorry, I'm too used to it...

@robert-alfaro robert-alfaro deleted the mbed-tls-try2 branch January 22, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tve tve tve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-alfaro @tve @Bmooij