Process: use process instead of typed-process
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielhdt
approved these changes
Feb 2, 2023
facundominguez
approved these changes
Feb 2, 2023
Co-authored-by: Facundo Domínguez <[email protected]>
Flake edited to please shellcheck
This reverts commit 7ad2f1c. The markdown-link-check CI failure seems to have been only temporary. I'm thus reverting the commit as an https link is better than an http one.
facundominguez
approved these changes
Feb 2, 2023
0xd34df00d
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the
typed-processlibrary is at the root of #15. This PR replaces it with theprocesslibrary it builds upon anyways. Notable changes includeProcess.waitfunction was removed: it's not strictly necessary and was annoying to implement aswaitForProcessdoesn't automatically close the I/O handlesmanualExitandsettingOptions(its advanced part) examples were merged into the newunderlyingProcessexample, which shows how to use the internals of theHandledatatype to tweak the behavior of the process and close it manuallyBefore merging this, we should check that
Backends.Process: the test-suite may fail randomly #15 and gets rid of the failures in the CI ofLanguage.Fixpoint.Smt.Interface: usesmtlib-backendsfor managing the solver process ucsd-progsys/liquid-fixpoint#641