Skip to content

Double-click required to open RecordTable cell on iOS #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Devessier opened this issue Nov 13, 2024 · 3 comments
Closed

Double-click required to open RecordTable cell on iOS #178

Devessier opened this issue Nov 13, 2024 · 3 comments
Assignees
Labels
prio: low scope: front Issues that are affecting the frontend side only

Comments

@Devessier
Copy link

Devessier commented Nov 13, 2024

Clicking twice on RecordTable cells is required to open them on iOS.

According to my research, there are a few things that can make it necessary to click twice on an element to open it on iOS:

  • The element might have a :hover pseudo-selector; iOS chooses to display the hover state on the first click, then trigger the actual onClick listener on the second click
  • The element might have mouse event listeners, like onMouseStart; in that case, the onClick listener will be called on the second click

Some references:

We must examine every use case and ensure that Twenty's website is usable on mobile devices.

I think the bug for RecordTable cells is not caused by a hover state but by the mouse event listeners. I couldn't find any hover state, and things worked when I removed the listeners, as shown below:

ScreenFlow.mp4

That said, I don't know what the best fix would be. I may have missed another reason during my research.

We could disable mouse listeners where appropriate when the user's device doesn't support hovering. This article explains the media queries we could use: https://www.smashingmagazine.com/2022/03/guide-hover-pointer-media-queries/.

@Devessier
Copy link
Author

As seen with @charlesBochet, this issue is not a priority right now. We'll postpone it.

@Bonapara
Copy link
Member

Can you add labels @Devessier? 🙏

@Devessier Devessier added scope: front Issues that are affecting the frontend side only prio: low labels Nov 18, 2024
@Bonapara Bonapara transferred this issue from twentyhq/twenty Jan 13, 2025
@Devessier
Copy link
Author

The problem remains but is low priority. Closing for now.

@Devessier Devessier closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: low scope: front Issues that are affecting the frontend side only
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants