chore(modal-dialog-primitive): upgrade reach dialog #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richbachman
commented
May 18, 2021
•
richbachman
commented
- Upgraded Reach/Dialog which fixes the test times when a focusable element is in a dialog.
- Upgraded React-Spring to the most recent stable version to fix a TS bug with opacity: 9.0.0-beta.1: Incompatible types/"Type […] is not assignable" pmndrs/react-spring#653.
- Added a test to Modal which renders a modal with focusable elements
🦋 Changeset detectedLatest commit: ff98556 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ff98556:
|
|
Size Change: +219 B (0%) Total Size: 530 kB
ℹ️ View Unchanged
|
richbachman
force-pushed
the
upgrade-reach
branch
from
3ff7a08 to
1beb31d
Compare
richbachman
added
the
Area: Components
gloriliale
reviewed
May 19, 2021
gloriliale
approved these changes
May 19, 2021
SiTaggart
approved these changes
May 19, 2021
richbachman
force-pushed
the
upgrade-reach
branch
from
1beb31d to
ff98556
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.